Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start making more windows friendly #59

Closed
wants to merge 6 commits into from

Conversation

rowanwins
Copy link
Contributor

@rowanwins rowanwins commented Sep 1, 2018

Inline with #58 I took a quick stab at making this repo a bit more windows friendly.

The noticable changes are

  • rewriting the setup_data.sh as a node script
    • Looks to be working for me except for the color images section - my machine is missing the osgeo python library for some reason, I'll look into why this might be happening...
  • A few minor tweaks to the package.json scripts to use shx which is cross-platform commands for stuff like rm, and also cross-env for environment variables

@rowanwins
Copy link
Contributor Author

Doh that last rollup commit wasn't supposed to land here sorry - but anyway, seems to be working, at the moment it's just outputting a commonjs bundle, but with a bit of extension we could output a version targeted for browsers.

@constantinius
Copy link
Member

@rowanwins Thanks for this PR. Regarding the commits added by accident: could you try to remove them? I've searched a bit and found some possible solutions: https://www.burntfen.com/2015-10-30/how-to-amend-a-commit-on-a-github-pull-request

It would be fine to use the one option to just add a commit that undos the rollup based stuff, then I'll just squash and merge, so no traces of the hiccup remain :)

@rowanwins
Copy link
Contributor Author

Think I'm going to simply close to pull request and resubmit, don't seem to be able to make those erroneous commits disappear

@rowanwins rowanwins closed this Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants